tag:blogger.com,1999:blog-1157206974462930369.post8409653776047871252..comments2007-07-25T09:50:52.594-07:00Adam Cablerhttp://www.blogger.com/profile/16116068837432398180noreply@blogger.comBlogger6125tag:blogger.com,1999:blog-1157206974462930369.post-80764783884798150062007-07-25T09:50:00.000-07:002007-07-25T09:50:00.000-07:00That's true, the label provider doesn't do anything special for reordered indices, but in this case there's no need. The compare method always uses the initial index and so does the label provider, so they should always match. Since this is on a column basis, it shouldn't care what order it is in the table. (I could easily have something wrong here, so please let me know)<BR/>However, if there were any issues with this, a method could be added to the inner class to look for a column by its name. But the label provider would have to be changed as well.Adam Cablerhttp://www.blogger.com/profile/16116068837432398180noreply@blogger.comtag:blogger.com,1999:blog-1157206974462930369.post-31090371304694252082007-07-24T22:39:00.000-07:002007-07-24T22:39:00.000-07:00but your label provider is not prepared to work with reordered indices? Or am I missing something?Tomhttp://www.blogger.com/profile/06619033174219683085noreply@blogger.comtag:blogger.com,1999:blog-1157206974462930369.post-19860413257835158442007-07-24T14:50:00.000-07:002007-07-24T14:50:00.000-07:00Hi Tom,<BR/> Thanks for the feedback. This does work if reordered since it uses the original index. Also, a name based lookup could be used just as well.<BR/> And it would be really nice to get something like this in for 3.4. If nobody is working on this, I would be happy to suggest something.Adam Cablerhttp://www.blogger.com/profile/16116068837432398180noreply@blogger.comtag:blogger.com,1999:blog-1157206974462930369.post-17797149851779228502007-07-24T14:38:00.000-07:002007-07-24T14:38:00.000-07:00The only reason is that we didn't had time for an API in 3.3. We first needed to fix all those inconsistency we inherited and we did a fairly good job. Does this code also work if you are reordering the columns? The bug request is https://bugs.eclipse.org/bugs/show_bug.cgi?id=166153?<BR/><BR/>We are always open for contributions. Think about an API and we'll help you to evolve it and if we are all satisfied the feature can be added. Most likely you should start with ViewerColumn-API which will be the home for such a JFace feature.Tomhttp://www.blogger.com/profile/06619033174219683085noreply@blogger.comtag:blogger.com,1999:blog-1157206974462930369.post-71511140618562856612007-07-24T13:31:00.000-07:002007-07-24T13:31:00.000-07:00Sure, that would be additional work, but most of the time, users want the values to be sorted based on what they see, which is the text, rather than some other value intrinsic to the object. I think this behavior would be pretty unexpected to the user.Adam Cablerhttp://www.blogger.com/profile/16116068837432398180noreply@blogger.comtag:blogger.com,1999:blog-1157206974462930369.post-40807436962914383042007-07-24T12:49:00.000-07:002007-07-24T12:49:00.000-07:00well, what about sorting values of datatypes other than String? ;)Ilya Shinkarenkohttp://www.blogger.com/profile/11667601571204987473noreply@blogger.com